New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for MySQL connection errors #1282

Merged
merged 5 commits into from Jan 22, 2014

Conversation

2 participants
@mickhansen
Contributor

mickhansen commented Jan 22, 2014

No description provided.

@mickhansen

This comment has been minimized.

Contributor

mickhansen commented Jan 22, 2014

@overlookmotel mind checking if this fixes your issue? it fixes the test case atleast

@mickhansen

This comment has been minimized.

Contributor

mickhansen commented Jan 22, 2014

Okay this is turning out harder than initially thought, some weird cruft code in the connector manager :/

mickhansen added some commits Jan 22, 2014

mickhansen added a commit that referenced this pull request Jan 22, 2014

Merge pull request #1282 from mickhansen/overlookmotel-test_bad_db_co…
…nn_failure

Fix for MySQL connection errors

@mickhansen mickhansen merged commit 8158387 into sequelize:master Jan 22, 2014

1 check passed

default The Travis CI build passed
Details

@mickhansen mickhansen deleted the mickhansen:overlookmotel-test_bad_db_conn_failure branch Jan 22, 2014

@overlookmotel

This comment has been minimized.

Contributor

overlookmotel commented Jan 23, 2014

Yup, that did the trick. Nice one!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment