Adding HAVING clause support to generic query generator#1286
Merged
mickhansen merged 7 commits intosequelize:masterfrom Jan 24, 2014
Merged
Adding HAVING clause support to generic query generator#1286mickhansen merged 7 commits intosequelize:masterfrom
mickhansen merged 7 commits intosequelize:masterfrom
Conversation
Contributor
|
Please do provide unit tests when introducing new functionality, else we will have no clue if we break it later on. |
Author
|
Just pushed some commits with bugfixes, improvements, code style, and unit tests :) |
Contributor
|
Great stuff, i see you added tests to mysql query generator, mind adding to sqlite and postgres aswell? :) |
Added Postgres and SQLite unit tests
Author
|
Here it is for you :-) |
Contributor
|
Ah, we merged some work in the meanwhile, mind rebasing? I cant merge automatically. |
added 2 commits
January 24, 2014 15:54
Conflicts: lib/dialects/abstract/query-generator.js
Author
|
Just pushed the merge. Let's wait for Travis to complete the build. |
Contributor
|
Sweet :) |
Contributor
|
Mind adding a small doc to the original description of this PR describing how to use it? |
mickhansen
added a commit
that referenced
this pull request
Jan 24, 2014
Adding HAVING clause support to generic query generator
Author
|
@mickhansen Done. Does it look okay for you? |
Contributor
|
@OtaK Perfect! Thank you for your work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi guys, hi @sdepold,
As I needed it, I added HAVING clause support to Sequelize's generic query generator.
Do I need to provide unit tests or is it okay like that ?
HOW TO USE
As the specification says,
HAVINGclauses are syntactically the same asWHEREclauses.So in your
Model.findAll()for example, provide ahavingoption in the hash.Like this :