New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Affected rows #1293

Merged
merged 3 commits into from Jan 25, 2014

Conversation

2 participants
@janmeier
Member

janmeier commented Jan 25, 2014

Closes #921

janmeier added some commits Jan 25, 2014

@@ -650,7 +651,7 @@ module.exports = (function() {
.success(function(results){
emitter.query = { sql: sql }
emitter.emit('sql', sql)
emitter.emit('success', results[1])
emitter.emit('success', results[0])

This comment has been minimized.

@mickhansen

mickhansen Jan 25, 2014

Contributor

What does this signify?

This comment has been minimized.

@janmeier

janmeier Jan 25, 2014

Member

Honestly, I have no idea. Bulkdelete or update never returned a value before...

This comment has been minimized.

@mickhansen

mickhansen Jan 25, 2014

Contributor

So results[1] was just ... nada?

This comment has been minimized.

@janmeier

janmeier Jan 25, 2014

Member

In the tests I did, yes. And no unit tests seem to be expecting a value

mickhansen added a commit that referenced this pull request Jan 25, 2014

@mickhansen mickhansen merged commit f14b8d7 into sequelize:master Jan 25, 2014

1 check passed

default The Travis CI build passed
Details

@janmeier janmeier deleted the janmeier:affectedRows branch Jan 25, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment