New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include: support .and()/.or() #1361

Merged
merged 4 commits into from Feb 7, 2014

Conversation

2 participants
@mickhansen
Contributor

mickhansen commented Feb 7, 2014

No description provided.

mickhansen added a commit that referenced this pull request Feb 7, 2014

Merge pull request #1361 from sequelize/include-and-or-tests
Include: support .and()/.or() - Fixes #1341 & #1291

@mickhansen mickhansen merged commit bad4f0b into master Feb 7, 2014

1 check was pending

default The Travis CI build is in progress
Details

@mickhansen mickhansen deleted the include-and-or-tests branch Feb 7, 2014

@maximeCony

This comment has been minimized.

Contributor

maximeCony commented Feb 12, 2014

Thank you, that's just what I needed!
However this is only implemented in the 1.7.x branch, could you implement it also in the 2.x.x?

@mickhansen

This comment has been minimized.

Contributor

mickhansen commented Feb 12, 2014

@maximeCony have you checked that we didn't merge it already?

@mickhansen

This comment has been minimized.

Contributor

mickhansen commented Feb 12, 2014

@maximeCony this is included in 1.7.0rc5 which means it's in 2.0.0dev5 too

@maximeCony

This comment has been minimized.

Contributor

maximeCony commented Feb 12, 2014

I couldn't find it in 2.0.0dev5 but it's included in 2.0.0dev6. Thanks again @mickhansen!

@mickhansen

This comment has been minimized.

Contributor

mickhansen commented Feb 12, 2014

@maximeCony yea something must've gone wrong with dev5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment