Skip to content

Eager loading all associations#1421

Merged
mickhansen merged 7 commits intosequelize:masterfrom
overlookmotel:include-all
Feb 23, 2014
Merged

Eager loading all associations#1421
mickhansen merged 7 commits intosequelize:masterfrom
overlookmotel:include-all

Conversation

@overlookmotel
Copy link
Copy Markdown
Contributor

PR for #1219

@overlookmotel
Copy link
Copy Markdown
Contributor Author

@mickhansen Finally finished this!
All tests pass on MySQL.

mickhansen added a commit that referenced this pull request Feb 23, 2014
@mickhansen mickhansen merged commit 60bd58c into sequelize:master Feb 23, 2014
@overlookmotel overlookmotel deleted the include-all branch February 24, 2014 01:21
@overlookmotel
Copy link
Copy Markdown
Contributor Author

@mickhansen Thanks for merging.

@mickhansen
Copy link
Copy Markdown
Contributor

@overlookmotel anytime ;)

@nomadster
Copy link
Copy Markdown

When rc9 will be available on npm? I am doing a benchmark on some ndoe's orm and really would like to use sequelize but have only rc8 available...

@mickhansen
Copy link
Copy Markdown
Contributor

@nomadster need to close out a few issues before releasing rc9, which hopefully should be the actual 1.7.0 release. Why would you need include:all to do a benchmark though?

@nomadster
Copy link
Copy Markdown

From sequelize website:

Changes in v1.7.0 rc9
fixes performance regression introduced in rc7

So according to your website rc9 is already out there and fixes performance issues but I can't find it on npm. Last release available is rc8 :)

@mickhansen
Copy link
Copy Markdown
Contributor

Website generator most be ignoring the (next) part from the changelog.
I just released rc9 with a hotfix included.

@mickhansen
Copy link
Copy Markdown
Contributor

I totally forgot about the performance regression fix, obviously you need that for a benchmark :D

@nomadster
Copy link
Copy Markdown

👍 :)

@janmeier janmeier mentioned this pull request Mar 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants