New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix transaction timeouts for postgres #1429

Merged
merged 8 commits into from Feb 25, 2014

Conversation

3 participants
@sdepold
Member

sdepold commented Feb 25, 2014

This PR fixes the way pooling is established for postgres. Furthermore transactions are now properly using pooling with both 1 max and 1 min connection. This way transactions are using the pooling's timing configuration.

this.client.connect(function(err, client, done) {
responded = true
connectCallback(err, client || self.client, done)
})
// If we didn't ever hear from the client.connect() callback the connection timedout, node-postgres does not treat this as an error since no active query was ever emitted
// If we didn't ever hear from the client.connect() callback the connection timeout, node-postgres does not treat this as an error since no active query was ever emitted

This comment has been minimized.

@mickhansen

mickhansen Feb 25, 2014

Contributor

Actually it should be 'timed out' ;)

mickhansen added a commit that referenced this pull request Feb 25, 2014

Merge pull request #1429 from sequelize/hotfix/transaction_timeout
Fix transaction timeouts for postgres

@mickhansen mickhansen merged commit 46da0e5 into master Feb 25, 2014

1 check passed

default The Travis CI build passed
Details
@ptmt

This comment has been minimized.

ptmt commented Feb 26, 2014

I've tried this patch in sandbox and production environments both and looks like it works, including integration tests.

Thanks guys, you are awesome!

@mickhansen

This comment has been minimized.

Contributor

mickhansen commented Feb 26, 2014

@UnknownException Great, thanks for verifying!
We should be about ready for a stable 1.7 release.

@janmeier janmeier deleted the hotfix/transaction_timeout branch Jul 18, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment