Fix transaction timeouts for postgres#1429
Merged
mickhansen merged 8 commits intomasterfrom Feb 25, 2014
Merged
Conversation
Contributor
There was a problem hiding this comment.
Actually it should be 'timed out' ;)
mickhansen
added a commit
that referenced
this pull request
Feb 25, 2014
Fix transaction timeouts for postgres
|
I've tried this patch in sandbox and production environments both and looks like it works, including integration tests. Thanks guys, you are awesome! |
Contributor
|
@UnknownException Great, thanks for verifying! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the way pooling is established for postgres. Furthermore transactions are now properly using pooling with both 1 max and 1 min connection. This way transactions are using the pooling's timing configuration.