fix(dao): HSTORE checking like ENUM

[tomchentw]

This allows user can define HSTORE attribute directly.

define like this

var Task = sequelize.define('Task', {
  title: Sequelize.STRING,
  description: Sequelize.TEXT,
  deadline: Sequelize.HSTORE
})

instead of

deadline: {
  type: Sequelize.HSTORE
}

I think I have to write a test case to reflect this?

[janmeier]

Looks good :)

Yes, a test would be very awesome. A good place to put it would probably be to add it in data-types.test.js. Would you mind adding a test for ENUM as well? A simple test that checks that .sync does not return any errors would be fine.

[mickhansen]

Not a huge fan of matching against toString().
But i guess we're already doing that so...

[tomchentw]

Thanks for the direction of @janmeier ! But I have to sleep now. Will push some tests later on.

@mickhansen, yeah, I think so.

To be honest, this is a huge project and you guys are doing really awesome. 👍

[tomchentw]

@janmeier I cannot find a correct way to write test against this. Could you give me a hand?

I've also fix several bugs in the following commits (those are with tests).

[janmeier]

@tomchentw Actually we already have tests for enums I just realized, so that's fine. And your test already uses both ways of declaring a HSTORE column. No more tests needed from my point of view.

I think this looks pretty ready to merge - @mickhansen

[mickhansen]

@janmeier i've had 2 beers so i'll defer to your judgement.

[janmeier]

In that case it's a merge :)

[tomchentw]

@mickhansen I like your comment! ha
@janmeier :) Thank you guys!