feat(oracle): add width support for numerictype#16073
Merged
WikiRik merged 2 commits intosequelize:v6from Jun 1, 2023
Merged
Conversation
WikiRik
approved these changes
Jun 1, 2023
Member
|
I'll slowly merge the 4 oracle PRs today and then trigger the release for a new version, just fyi |
Contributor
|
🎉 This PR is included in version 6.32.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Description Of Change
Adding precision and scale to
numeric datatypes(INTEGER and DECIMAL).INTEGER
If width is provided:
id: { type: Sequelize.INTEGER(3) //width provided },will generate
ID NUMBER(3,0)If width is not provided:
id: { type: Sequelize.INTEGER //width not provided },will generate
ID INTEGERSMALLINT
If width is provided:
id: { type: Sequelize.SMALLINT(3) //width provided },will generate
ID NUMBER(3,0)If width is not provided:
id: { type: Sequelize.SMALLINT //width not provided },will generate
ID SMALLINTDECIMAL
If precision and scale is provided:
id: { type: Sequelize.DECIMAL(3,2) },will generate
ID NUMBER(3,2)If precision and scale is not provided:
id: { type: Sequelize.DECIMAL },will generate
ID NUMBERIf only precision is provided:
id: { type: Sequelize.DECIMAL(10) },will generate
ID NUMBER(10)