Conversation
lib/dialects/mysql/index.js
Outdated
There was a problem hiding this comment.
@mickhansen Do you think this is okay - tacking the actual query string into the supports object so we only have to write the code in abstract QG, or should we have a separate object for this?
There was a problem hiding this comment.
@janmeier not sure, this seems reasonable, although i assume you mean you only write the code in the dialect (Rather than the abstracg QG)
There was a problem hiding this comment.
What i meant was we only need to add the code that adds FOR SHARE / LOCK IN SHARE MODE in the abstract query generator, while the string for the specific dialect is in index
Support for FOR UPDATE and FOR SHARE queries
|
@janmeier I thought that was a bug in documentation :) Maybe it's better to clarify that the second row is just for example? |
|
@DenisGorbachev Agreed - PR welcome :) |
4 participants
This PR is mostly just a travis runner before I merge this in :) .Closes #1442