Add support for keyword after in options of a field#3166
Add support for keyword after in options of a field#3166sitexw wants to merge 1 commit intosequelize:masterfrom sitexw:master
after in options of a field#3166Conversation
…rations), only for MySQL. And add unit test.
|
Up |
|
@sitexw can you do a rebase? |
|
I can not make the rebase, can you give me quickly what to do? |
|
ping @sitexw |
|
Hi, I'm sorry but I have not managed / understood why we must make a rebase. But also, what I have to commit to change. |
|
@sitexw You have to rebase so i can merge it. The branch is out of sync with master. |
Done |
Add support for keyword `after` in options of a field. Closes #3166
Add support for keyword `after` in options of a field. Closes sequelize#3166
|
This change doesn't add support in "options" of a field, it adds to "attributes", causing a clash with the queryInterface API documentation (https://sequelize.org/api/v6/class/src/dialects/abstract/query-interface.js~queryinterface#instance-method-addColumn) which in the example shows "after" as a key within "options" when it's actually within "attributes" I think it makes sense to keep it as a column attribute, but the docs should match to avoid confusion. This example: should probably look like this instead: |
Add support for keyword
afterin options of a field (useful for migrations), only for MySQL.And add unit test.