New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unhandled rejection if errors occur in a committed transaction. Fixes #3689 #3726

Merged
merged 1 commit into from May 17, 2015

Conversation

2 participants
@BridgeAR
Contributor

BridgeAR commented May 15, 2015

No description provided.

@BridgeAR

This comment has been minimized.

Contributor

BridgeAR commented May 15, 2015

This fixes #3689

@BridgeAR BridgeAR changed the title from Fix unhandled rejections if an error occurs in a transaction that was… to Fix unhandled rejection if errors occur in a committed transaction May 15, 2015

@BridgeAR BridgeAR changed the title from Fix unhandled rejection if errors occur in a committed transaction to Fix unhandled rejection if errors occur in a committed transaction. Fixes #3689 May 16, 2015

@@ -73,6 +73,30 @@ describe(Support.getTestDialectTeaser('Transaction'), function() {
expect(t.finished).to.be.equal('rollback');
});
});
if (dialect === 'postgres' || dialect === 'mssql') {

This comment has been minimized.

@mickhansen

mickhansen May 17, 2015

Contributor

what's the issue with mysql here?

This comment has been minimized.

@BridgeAR

BridgeAR May 17, 2015

Contributor

Mysql returns the values and does not throw. But that does not really matter as my fix works for every dialect if something like that happens in that dialect.

@mickhansen

This comment has been minimized.

Contributor

mickhansen commented May 17, 2015

Looks good, just the single comment and a rebase.

@mickhansen mickhansen merged commit ece0d9e into sequelize:master May 17, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment