New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

instance.changed() in beforeUpdate hook would always be false. Fixes #3631 #3727

Merged
merged 1 commit into from May 17, 2015

Conversation

3 participants
@BridgeAR
Contributor

BridgeAR commented May 15, 2015

I also removed some old callbacks from some hooks.

@BridgeAR

This comment has been minimized.

Contributor

BridgeAR commented May 16, 2015

Green build

@janmeier

This comment has been minimized.

Member

janmeier commented May 17, 2015

LGTM - needs a rebase

// Set the changed fields on the instance
Utils._.forIn(valuesUse, function(newValue, attr) {
if (newValue !== dao._previousDataValues[attr]) {
dao.setDataValue(attr, newValue);

This comment has been minimized.

@mickhansen

mickhansen May 17, 2015

Contributor

Better to call instance.changed(field) rather than setting the value again.

@mickhansen mickhansen merged commit ba537e9 into sequelize:master May 17, 2015

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment