instance.changed() in beforeUpdate hook would always be false. Fixes #3631#3727
Merged
mickhansen merged 1 commit intosequelize:masterfrom May 17, 2015
fintura:fix-update-hook
Merged
instance.changed() in beforeUpdate hook would always be false. Fixes #3631#3727mickhansen merged 1 commit intosequelize:masterfrom fintura:fix-update-hook
mickhansen merged 1 commit intosequelize:masterfrom
fintura:fix-update-hook
Conversation
Contributor
Author
|
Green build |
Member
|
LGTM - needs a rebase |
Contributor
There was a problem hiding this comment.
Better to call instance.changed(field) rather than setting the value again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I also removed some old callbacks from some hooks.