Add failing test case for findAndCountAll with a include and where#4016
Merged
janmeier merged 1 commit intosequelize:masterfrom Jun 28, 2015
Merged
Conversation
janmeier
added a commit
that referenced
this pull request
Jun 28, 2015
Add failing test case for findAndCountAll with a include and where
janmeier
added a commit
that referenced
this pull request
Jun 28, 2015
Member
|
Fixed by adding a distinct to the count part when there are any include on the count |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a test case for
findAndCountAllreturning an incorrect value forresult.count, as the where statement in the include makes thecount()sql function counts all rows instead (3 in this case) of only matchingFoos (2 in this case).See issue #4015