New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(model/attributes): return type and dependency fields for VIRTUAL #4420

Merged
merged 2 commits into from Sep 3, 2015

Conversation

1 participant
@mickhansen
Contributor

mickhansen commented Sep 2, 2015

/cc @janmeier

}
}.bind(this));
options.attributes = _.without.apply(this, [options.attributes].concat(this._virtualAttributes));
options.attributes = _.unique(options.attributes);
}

This comment has been minimized.

@mickhansen

mickhansen Sep 2, 2015

Contributor

Maybe pull all this into mapOptionFieldNames so it will work out of the box for includes aswell?
(although that will break some of the naming ;p)

mickhansen added a commit that referenced this pull request Sep 3, 2015

Merge pull request #4420 from sequelize/feat-virtual-return-n-fields
feat(model/attributes): return type and dependency fields for VIRTUAL

@mickhansen mickhansen merged commit f36023c into master Sep 3, 2015

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details

@mickhansen mickhansen deleted the feat-virtual-return-n-fields branch Sep 3, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment