Rename Instance private options and __options#4429
Merged
janmeier merged 1 commit intosequelize:masterfrom Sep 9, 2015
Merged
Conversation
- Possibly fix sequelize#4423 - Rename Instance `options` to `$options` to prevent value overwriting with models that have a column named `options` - Also rename Instance `__options` to `$modelOptions` to avoid confusion between $options and __options.
Member
|
Looks good to me - good catch on the This shouldn't require a major version right @mickhansen ? Do you agree that if people depend on |
Contributor
|
It's not documented anywhere, so can hardly be considered public API. I personally probably have some code dependant on that somewhere, but yeah i'd agree that if people are using non-public stuff they can't expect SEMVER to apply there. |
Member
|
Cool, I'll merge and add it to the changelog then |
janmeier
added a commit
that referenced
this pull request
Sep 9, 2015
Rename Instance private options and __options
janmeier
added a commit
to janmeier/sequelize
that referenced
this pull request
Sep 9, 2015
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
optionsto$optionsto prevent valueoverwriting with models that have a column named
options__optionsto$modelOptionsto avoid confusionbetween $options and __options.