Feature #4527 "skip" option for custom validators

[superclarkk]

Enable .validate(options.skip) to skip specific model/custom validators #4527
Return false to exit iteration early when using _.each and _.forIn , as per lodash docs

[mickhansen]

Concerning BC: i don't think this constitutes a breaking change since i don't believe you would have model validators named the same as attributes.

/cc @janmeier

[mickhansen]

Is the iteration supposed to be exited early though? skip might match the first field, should still validate all the other fields.

[superclarkk]

It was exiting early with just "return", but the lodash docs state that it should be return false. I changed this line just so that it was consistent with my main changes.

[mickhansen]

Are you absolutely sure about that? lodash docs says you have to explicitely return false.
If it's currently exiting the loop early with just return that would be a bug.

[mickhansen]

https://github.com/lodash/lodash/blob/master/lodash.js#L3352 it tests for explicit false, return undefined would not break loop.

[superclarkk]

@mickhansen If by "attributes" you mean fields (table columns), then you are correct. An error is thrown if a custom validator (model validator) and an attribute have the same name.

[mickhansen]

@superclarkk i did mean model/table fields, thanks for confirming :)

[mickhansen]

Published in 3.9.0