Skip to content

Update dependencies#4594

Merged
mickhansen merged 1 commit intosequelize:masterfrom
fintura:master
Sep 30, 2015
Merged

Update dependencies#4594
mickhansen merged 1 commit intosequelize:masterfrom
fintura:master

Conversation

@BridgeAR
Copy link
Copy Markdown
Contributor

Bluebird has no BC changes and they are very careful not to break anything, so I guess it's fine to get minor updates instead of just patches.
Wellknown got a new feature without BC.
Dottie has no changelog but if I read the commit messages correct version 1.0 is backwards compatible.

Coffee-script is not used in sequelize.

changelog.md Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does changing the dependencies warrant a minor bump?
Are we as a package providing any new features by upgrading?

/cc @janmeier

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you use shrinkwrap the peer dependencies have to be ok. Otherwise you can't build your shrinkwrap file. That's why I consider it as a minor bump.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shrinkwrap doesn't work currently with sequelize? If not i'd say this is a bug fix then, not a new feature.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does not work with sequelize if you want to use bluebird 2.10.x. That's because sequelize requires bluebird < 2.10.x.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because of our ~?
Probably best to just use Next untill we actually cut a release.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yepp, because of the tilde. I'll rebase it in a few minutes.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

mickhansen added a commit that referenced this pull request Sep 30, 2015
@mickhansen mickhansen merged commit 6dc255e into sequelize:master Sep 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants