New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #4594

Merged
merged 1 commit into from Sep 30, 2015

Conversation

2 participants
@BridgeAR
Contributor

BridgeAR commented Sep 30, 2015

Bluebird has no BC changes and they are very careful not to break anything, so I guess it's fine to get minor updates instead of just patches.
Wellknown got a new feature without BC.
Dottie has no changelog but if I read the commit messages correct version 1.0 is backwards compatible.

Coffee-script is not used in sequelize.

@@ -1,3 +1,12 @@
# 3.11.0

This comment has been minimized.

@mickhansen

mickhansen Sep 30, 2015

Contributor

Does changing the dependencies warrant a minor bump?
Are we as a package providing any new features by upgrading?

/cc @janmeier

This comment has been minimized.

@BridgeAR

BridgeAR Sep 30, 2015

Contributor

If you use shrinkwrap the peer dependencies have to be ok. Otherwise you can't build your shrinkwrap file. That's why I consider it as a minor bump.

This comment has been minimized.

@mickhansen

mickhansen Sep 30, 2015

Contributor

shrinkwrap doesn't work currently with sequelize? If not i'd say this is a bug fix then, not a new feature.

This comment has been minimized.

@BridgeAR

BridgeAR Sep 30, 2015

Contributor

It does not work with sequelize if you want to use bluebird 2.10.x. That's because sequelize requires bluebird < 2.10.x.

This comment has been minimized.

@mickhansen

mickhansen Sep 30, 2015

Contributor

Because of our ~?
Probably best to just use Next untill we actually cut a release.

This comment has been minimized.

@BridgeAR

BridgeAR Sep 30, 2015

Contributor

Yepp, because of the tilde. I'll rebase it in a few minutes.

This comment has been minimized.

@BridgeAR

BridgeAR Sep 30, 2015

Contributor

Done

Ruben Bridgewater

mickhansen added a commit that referenced this pull request Sep 30, 2015

Merge pull request #4594 from fintura/master
Update dependencies

@mickhansen mickhansen merged commit 6dc255e into sequelize:master Sep 30, 2015

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment