Make binary verbose#612
Merged
sdepold merged 5 commits intosequelize:masterfrom May 13, 2013
terraflubb:make_binary_verbose
Merged
Make binary verbose#612sdepold merged 5 commits intosequelize:masterfrom terraflubb:make_binary_verbose
sdepold merged 5 commits intosequelize:masterfrom
terraflubb:make_binary_verbose
Conversation
Still defaults to 'development' if NODE_ENV isn't set so backwards compatibility is ensured.
Also replaced one thrown error with a console.log. The rest of the errors were not thrown, and since this file is run from the shell, it will be an edge case that it will ever be caught. It looks messy when it happens. So it now returns an exit code of 1 to indicate things went sideways.
Because I always forget to add one to 'down' and then my migrations don't undo. Also upgraded a ==.
And quit with a code after outputting it.
Closed
Member
|
sounds good, will check later :) |
Member
|
thanks a lot :) |
|
👍 So...can I now work on what we discussed at #610 ? |
Contributor
Author
|
I'd say go for it... it would be helpful I think. I'd like to take a crack at grunt integration, and I think that it would be helpful. |
|
Great, looking forward to the weekend. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #610 , might be a starting point if @leostera feels like going to town on this sometime.
Here are a handful of improvements to make the sequelize binary a bit more verbose (including the migrations).
sequelize -m -e testwill run in the test environmentconfig/config.jsonoutput a more useful error. 4c23c8adone()to migration skeletons 6f65e6ddown()so my migrations hang, I can't be alone, and I think it makes sense for it to be part of the skeleton.