Skip to content

add options.silent support for Instance increment and decrement.#6793

Merged
janmeier merged 1 commit intosequelize:v3from
iyuq:v3
Nov 7, 2016
Merged

add options.silent support for Instance increment and decrement.#6793
janmeier merged 1 commit intosequelize:v3from
iyuq:v3

Conversation

@iyuq
Copy link
Copy Markdown
Contributor

@iyuq iyuq commented Nov 3, 2016

Thanks for wanting to fix something on Sequelize - we already love you long time! Please delete this text and fill in the template below. If unsure about something, just do as best as you're able.

If your PR only contains changes to documentation, you may skip the template below.

Pull Request check-list

Please make sure to review and check all of these items:

  • [√ ] Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does your issue contain a link to existing issue (Closes #[issue]) or a description of the issue you are solving?
  • [√] Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Have you added an entry under Future in the changelog?

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

add options.silent support for Instance increment and decrement method, so you can use

user.increment('count', {silent: true} 

to prevent update the updatedAt field.

But I got a error run npm run docs, so I don't update the docs, please help me do this.

@mention-bot
Copy link
Copy Markdown

@iyuq, thanks for your PR! By analyzing the history of the files in this pull request, we identified @BridgeAR, @mbroadst and @mickhansen to be potential reviewers.

@iyuq
Copy link
Copy Markdown
Contributor Author

iyuq commented Nov 3, 2016

@mention-bot you are welcome!

@codecov-io
Copy link
Copy Markdown

codecov-io commented Nov 3, 2016

Current coverage is 93.84% (diff: 100%)

Merging #6793 into v3 will not change coverage

Powered by Codecov. Last update 15ee1c1...9f40ffb

@sushantdhiman
Copy link
Copy Markdown
Contributor

Need this for master as well @iyuq

Copy link
Copy Markdown
Member

@janmeier janmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be pretty easy to just cherry pick this to master

@iyuq
Copy link
Copy Markdown
Contributor Author

iyuq commented Nov 3, 2016

@felixfbecker okay, I will add a pull request for master latter. So this PR is acceptable?

@iyuq
Copy link
Copy Markdown
Contributor Author

iyuq commented Nov 3, 2016

I add this for master as well, see PR#6795, @felixfbecker

@janmeier janmeier merged commit 2fc4508 into sequelize:v3 Nov 7, 2016
@janmeier
Copy link
Copy Markdown
Member

janmeier commented Nov 7, 2016

Thanks a lot @iyuq ! :)

janmeier added a commit that referenced this pull request Nov 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants