New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add options.silent support for Instance increment and decrement. #6793

Merged
merged 1 commit into from Nov 7, 2016

Conversation

7 participants
@iyuq
Contributor

iyuq commented Nov 3, 2016

Thanks for wanting to fix something on Sequelize - we already love you long time! Please delete this text and fill in the template below. If unsure about something, just do as best as you're able.

If your PR only contains changes to documentation, you may skip the template below.

Pull Request check-list

Please make sure to review and check all of these items:

  • [√ ] Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does your issue contain a link to existing issue (Closes #[issue]) or a description of the issue you are solving?
  • [√] Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Have you added an entry under Future in the changelog?

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

add options.silent support for Instance increment and decrement method, so you can use

user.increment('count', {silent: true} 

to prevent update the updatedAt field.

But I got a error run npm run docs, so I don't update the docs, please help me do this.

@mention-bot

This comment has been minimized.

mention-bot commented Nov 3, 2016

@iyuq, thanks for your PR! By analyzing the history of the files in this pull request, we identified @BridgeAR, @mbroadst and @mickhansen to be potential reviewers.

@iyuq

This comment has been minimized.

Contributor

iyuq commented Nov 3, 2016

@mention-bot you are welcome!

@codecov-io

This comment has been minimized.

codecov-io commented Nov 3, 2016

Current coverage is 93.84% (diff: 100%)

Merging #6793 into v3 will not change coverage

Powered by Codecov. Last update 15ee1c1...9f40ffb

@sushantdhiman

This comment has been minimized.

Member

sushantdhiman commented Nov 3, 2016

Need this for master as well @iyuq

@janmeier

Should be pretty easy to just cherry pick this to master

@iyuq

This comment has been minimized.

Contributor

iyuq commented Nov 3, 2016

@felixfbecker okay, I will add a pull request for master latter. So this PR is acceptable?

@iyuq

This comment has been minimized.

Contributor

iyuq commented Nov 3, 2016

I add this for master as well, see PR#6795, @felixfbecker

@janmeier janmeier merged commit 2fc4508 into sequelize:v3 Nov 7, 2016

4 checks passed

codecov/patch 100% of diff hit (target 93.84%)
Details
codecov/project 93.84% (+0.00%) compared to 15ee1c1
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@janmeier

This comment has been minimized.

Member

janmeier commented Nov 7, 2016

Thanks a lot @iyuq ! :)

janmeier added a commit that referenced this pull request Nov 7, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment