add options.silent support for Instance increment and decrement.#6793
Merged
janmeier merged 1 commit intosequelize:v3from Nov 7, 2016
Merged
add options.silent support for Instance increment and decrement.#6793janmeier merged 1 commit intosequelize:v3from
janmeier merged 1 commit intosequelize:v3from
Conversation
|
@iyuq, thanks for your PR! By analyzing the history of the files in this pull request, we identified @BridgeAR, @mbroadst and @mickhansen to be potential reviewers. |
Contributor
Author
|
@mention-bot you are welcome! |
Current coverage is 93.84% (diff: 100%)
|
Contributor
|
Need this for |
janmeier
approved these changes
Nov 3, 2016
Member
janmeier
left a comment
There was a problem hiding this comment.
Should be pretty easy to just cherry pick this to master
Contributor
Author
|
@felixfbecker okay, I will add a pull request for master latter. So this PR is acceptable? |
3 tasks
Contributor
Author
|
I add this for master as well, see PR#6795, @felixfbecker |
BridgeAR
approved these changes
Nov 3, 2016
Member
|
Thanks a lot @iyuq ! :) |
janmeier
added a commit
that referenced
this pull request
Nov 7, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for wanting to fix something on Sequelize - we already love you long time! Please delete this text and fill in the template below. If unsure about something, just do as best as you're able.
If your PR only contains changes to documentation, you may skip the template below.
Pull Request check-list
Please make sure to review and check all of these items:
npm run testornpm run test-DIALECTpass with this change (including linting)?Futurein the changelog?NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.
Description of change
add options.silent support for Instance increment and decrement method, so you can use
to prevent update the updatedAt field.
But I got a error run npm run docs, so I don't update the docs, please help me do this.