v3 Bugfix: Return value in MSSQL soft-delete#6916
Merged
sushantdhiman merged 1 commit intosequelize:v3from Nov 30, 2016
Merged
Conversation
lumaxis
force-pushed
the
bugfix/mssql-soft-delete-return
branch
from
5f240f7 to
9e28020
Compare
|
@lumaxis, thanks for your PR! By analyzing the history of the files in this pull request, we identified @felixfbecker, @janmeier and @cbauerme to be potential reviewers. |
Contributor
Author
|
I accidentally opened this against the wrong base branch first. Anything I can do to trigger CI again? |
Member
|
Push an empty commit or open a new pr :-) |
Contributor
|
Because the query type was not properly set when doing a soft delete, Sequelize tried to format the result in the wrong format: https://github.com/sequelize/sequelize/blob/cf232e76b46b7cb2fc98c455cc2010d520ca592d/lib/dialects/mssql/query.js#L186
lumaxis
force-pushed
the
bugfix/mssql-soft-delete-return
branch
from
9e28020 to
f329852
Compare
Current coverage is 93.88% (diff: 100%)
|
Contributor
Author
|
@janmeier @felixfbecker Thanks! Looking good 🙂 |
lumaxis
changed the title
Contributor
Author
|
@janmeier @felixfbecker What do you think about this change? |
Contributor
|
PR to master? |
lumaxis
changed the title
5 tasks
Contributor
Author
|
@felixfbecker Right, sorry! I don't use v4 personally but just opened #6930 which hopefully passes CI soon to 🙂 |
sushantdhiman
approved these changes
Nov 30, 2016
Contributor
|
Master fix merged at #6930 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
npm run testnpm run test-mssqlpass with this change (including linting)?Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?Futurein the changelog?Description of change
This fixes an issue where
undefinedwas returned when using a soft-delete on MSSQL because the query type of theUPDATEquery that ran the soft-delete was not properly set.