Skip to content

Fix getting true when upsert a row to its current value with mysql for Sequelize v3#6963

Merged
janmeier merged 1 commit intosequelize:v3from
salivarick:fix-6310-v3
Dec 8, 2016
Merged

Fix getting true when upsert a row to its current value with mysql for Sequelize v3#6963
janmeier merged 1 commit intosequelize:v3from
salivarick:fix-6310-v3

Conversation

@salivarick
Copy link
Copy Markdown

Fixed #6310 : added flags: '-FOUND_ROWS' at createConnection in mysql dialect.

This is the PR for v3 that I currently use.

Thanks

@mention-bot
Copy link
Copy Markdown

@daleoooo, thanks for your PR! By analyzing the history of the files in this pull request, we identified @harshithkashyap, @janmeier and @mickhansen to be potential reviewers.

@salivarick salivarick changed the title Fix getting true when upsert a row to its current value with mysql in Sequelize v3 Fix getting true when upsert a row to its current value with mysql for Sequelize v3 Dec 8, 2016
@codecov-io
Copy link
Copy Markdown

codecov-io commented Dec 8, 2016

Current coverage is 93.88% (diff: 100%)

Merging #6963 into v3 will not change coverage

Powered by Codecov. Last update 86c567d...e8f83a2

@salivarick
Copy link
Copy Markdown
Author

@janmeier
Please merge 😀

@janmeier janmeier merged commit 4f95f17 into sequelize:v3 Dec 8, 2016
@janmeier
Copy link
Copy Markdown
Member

janmeier commented Dec 8, 2016

👍

@salivarick salivarick deleted the fix-6310-v3 branch December 8, 2016 08:34
jharting added a commit to jharting/sequelize that referenced this pull request Apr 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants