Conversation
|
@nemisj, thanks for your PR! By analyzing the history of the files in this pull request, we identified @mickhansen, @BridgeAR and @janmeier to be potential reviewers. |
test/unit/instance/previous.test.js
Outdated
|
|
||
| describe(Support.getTestDialectTeaser('Instance'), function() { | ||
| describe('previous', function () { | ||
|
|
test/unit/instance/previous.test.js
Outdated
| var Model = current.define('Model', { | ||
| text: { | ||
| type: DataTypes.STRING | ||
| , get: function (name) { |
There was a problem hiding this comment.
no leading commas, in json object
|
@nemisj Need a PR to master before merging this |
Codecov Report
Continue to review full report at Codecov.
|
|
@sushantdhiman what do you mean? do I have to create the same PR for master branch? |
Yes, add same PR to master as well @nemisj |
|
@sushantdhiman i've added it - #7189 |
sushantdhiman
left a comment
sushantdhiman
left a comment
There was a problem hiding this comment.
Needs changelog, otherwise LGTM
|
@sushantdhiman how should this happen? Do I have to add it to this branch and then you will merge it? |
|
Yes, you need to add changelog |
|
@sushantdhiman, added to both PRs |
changelog.md
Outdated
| @@ -1,3 +1,6 @@ | |||
| # 3.30.2 | |||
test/unit/instance/previous.test.js
Outdated
| , DataTypes = require(__dirname + '/../../../lib/data-types') | ||
| , current = Support.sequelize; | ||
|
|
||
| describe(Support.getTestDialectTeaser('Instance'), function() { |
There was a problem hiding this comment.
Space before opening brackets function ()
|
done |
4 participants
Pull Request check-list
npm run testornpm run test-DIALECTpass with this change (including linting)?Futurein the changelog?Description of change
Previous method of the instance was working incorrectly