Merged
Conversation
sushantdhiman
commented
Nov 28, 2017
| return Promise.all(promises) | ||
| .then(function() { | ||
| // fetch OIDs ENUM, refresh them | ||
| return self.sequelize.query( |
Contributor
Author
There was a problem hiding this comment.
Sync will create new enum here, I couldn't find a better place to refresh oids
mickhansen
approved these changes
Nov 28, 2017
janmeier
reviewed
Nov 28, 2017
| return this.sequelize.getQueryInterface().pgListEnums(User.getTableName()); | ||
| }).then(function (enums) { | ||
| expect(enums).to.have.length(1); | ||
| expect(enums[0].enum_value).to.equal("{view,access,edit,write,check,delete}"); |
Member
There was a problem hiding this comment.
I don't know if this order would ever be different? Maybe do a substr + split and assert on the array of items
Contributor
Author
There was a problem hiding this comment.
Order wont change. I ensure you this wont turn into an intermittent failing test :D
| }); | ||
| }); | ||
|
|
||
| it('should be able to insert new record', function() { |
Member
There was a problem hiding this comment.
Add a test that check that you are not able to insert a value that's not part of the eunm
janmeier
approved these changes
Nov 28, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
npm run testornpm run test-DIALECTpass with this change (including linting)?Description of change
Add support for
ARRAY(ENUM)#1498