rawSelect does not bother to check whether it actually found a result before trying to access a result attribute ...#906
Closed
iamjochem wants to merge 1 commit intosequelize:masterfrom
Conversation
fixes a TypeError that occurs if a 'rawSelect' query does not return a row (data is null).
I discovered the problem trying perform a `Model.count()` in combination with a `group` option on a MySQL database,MySQL does not return a record for query such as this:
```sql
SELECT
count(*) AS `count`
FROM
`SomeTable`
WHERE
`category_id` = 1
GROUP BY
`my_grouping_field`
```
In Sequelize the previous query would be done like so:
```js
SomeTable.count({
group: 'my_grouping_field',
where: {
category_id: 1
}
});
```
assuming the `category_id` WHERE clause returns zero records you end up with the following TypeError:
```bash
TypeError: Cannot read property 'count' of null
at null.<anonymous> (some-project/node_modules/sequelize/lib/query-interface.js:314:28)
at EventEmitter.emit (events.js:117:20)
at null.<anonymous> (some-project/node_modules/sequelize/lib/dialects/mysql/query.js:32:14)
at Query.Sequence.end (some-project/node_modules/mysql/lib/protocol/sequences/Sequence.js:66:24)
at Query._handleFinalResultPacket (some-project/node_modules/mysql/lib/protocol/sequences/Query.js:139:8)
at Query.EofPacket (some-project/node_modules/mysql/lib/protocol/sequences/Query.js:123:8)
at Protocol._parsePacket (some-project/node_modules/mysql/lib/protocol/Protocol.js:169:24)
at Parser.write (some-project/node_modules/mysql/lib/protocol/Parser.js:62:12)
at Protocol.write (some-project/node_modules/mysql/lib/protocol/Protocol.js:36:16)
at write (_stream_readable.js:557:24)
```
janmeier
added a commit
that referenced
this pull request
Sep 16, 2013
Member
|
Merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes a TypeError that occurs if a 'rawSelect' query does not return a row (data is null).
I discovered the problem trying perform a
Model.count()in combination with agroupoption on a MySQL database,MySQL does not return a record for query such as this:In Sequelize the previous query would be done like so:
assuming the
category_idWHERE clause returns zero records you end up with the following TypeError: