Merged
Conversation
Member
|
wow. need to take some further time to review the code :) |
Contributor
Author
|
I know i'ts big and can seem scary at the first look, but let me give you guys an overview.
That's it. I tried to follow your code style, so it should not be that difficult to read. The tests also help to understand the purpose of the change, and are passing in all databases. If you guys need something from me in order to merge it, please tell me. I'll be glad to help. |
Member
|
pretty awesome stuff :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding support for filtering data through relationships. Good examples of this can be found in the file
test/associations/multiple-level-filters.test.jsHere is the added behavior:
By running this code, it sequelize will interpret the where clauses adding all the necessary joins to able to run the filter.
Hope you guys like it and consider the merging