🐞 Admin portal - Reorder candidates UI does not show the candidates text #2646
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the admin-portal “reorder candidates” UI so list rows display the candidate label (alias/name) instead of showing blank text, aligning the reorder widget with how other parts of the admin portal render entity display names.
Changes:
- Use the shared
useAliasRendererhook to derive the displayed row label for items being reordered. - Replace the previous
lineItem?.name ?? ""fallback with alias/name rendering consistent with i18n/presentation structures.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
BelSequent
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parent issue: https://github.com/sequentech/meta/issues/12050