Skip to content

🐞 Deleting election event does not remove the S3 event document files #2681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BelSequent wants to merge 7 commits into
base: release/9.0
Choose a base branch
from
Open

🐞 Deleting election event does not remove the S3 event document files #2681

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
93afdcc
🐞 Windmill fails to delete election event files on production AWS S3 …
BelSequent May 18, 2026
ae6e371
refactor: reuse shared s3 endpoint config builder
Copilot May 18, 2026
576c5e0
docs: clarify shared s3 config helper usage
Copilot May 18, 2026
7e4ef37
docs: restore get_s3_aws_config function docs
Copilot May 18, 2026
fdf1462
fix: use AWS SDK error metadata for robust S3 error handling
Copilot May 18, 2026
7566573
refine: improve error message clarity
Copilot May 18, 2026
79f997f
Review error handling and ai slop
BelSequent May 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions packages/sequent-core/src/services/connection.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,8 +202,7 @@ struct TokenResponseExtended {

/// Last access token can be reused if it´s not expired, this is to avoid
/// Keycloak having to hold one token per Api request which could lead quickly
/// to many thousands of tokens.
///
/// to many thousands of tokens.<br>
/// Keycloak can hold multiple tokens for the same client, so we do not care
/// about using the previous token if one thread read it and while didn´t send
/// it yet other thread wrote it. As long as it is not expired, we can reuse it.
Expand Down
Loading
Loading