fix(utils): clean the configured tensorboard_path, not only the runs/ dir#90
Merged
Merged
Conversation
… dir tensorboard_clean=True previously removed subdirectories of a hardcoded relative "runs" directory in the CWD and ignored tensorboard_path entirely - with an explicit path the flag deleted unrelated logs and left the actual log directory untouched. Now, when tensorboard_path is set, the configured directory itself is removed (and re-created empty by the writer), so every run starts with a fresh dashboard; without a path the legacy runs/ cleanup is kept. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tensorboard_clean=Truepreviously removed subdirectories of a hardcoded relativerunsdirectory in the CWD and ignoredtensorboard_pathentirely — with an explicit path the flag deleted unrelated logs and left the actual log directory untouched.Now, when
tensorboard_pathis set, the configured directory itself is removed (and re-created empty by the writer), so every run starts with a fresh dashboard. Without a path, the legacyruns/subdirectory cleanup is kept.test_clean_with_custom_tensorboard_pathupdated to the new semantics (stale event file removed, unrelatedruns/untouched)Enables
spotforecast2'sSpotOptimStrategyto defaulttensorboard_clean=Truefor fresh per-run dashboards.🤖 Generated with Claude Code