Use timeout seconds for task validation#2140
Open
PierreMesure wants to merge 2 commits intosequinstream:mainfrom
Open
Use timeout seconds for task validation#2140PierreMesure wants to merge 2 commits intosequinstream:mainfrom
PierreMesure wants to merge 2 commits intosequinstream:mainfrom
Conversation
dosubot
Bot
added
size:L
PierreMesure
force-pushed
the
use_timeout_seconds_for_task_validation
branch
from
e84b5aa to
9c65d3e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is PR 2 related to issue #2138. It is based on PR 1 but replaces the small changes I made there. I broke it down to simplify the review.
Instead of doing 5 retries with a total validation timeout of 3,2 seconds (or 10 as suggested in PR 1), the validation process now uses
timeout_secondsas the total timeout time. The tasks API is still polled with an exponential backoff from 200 to 10 000ms.This makes Sequin's behaviour more consistent as the same timeout value is used for Meilisearch and all the other sinks. It also lets the user steer how long they are willing to wait for Meilisearch's indexing before the task is resent.
EDIT: Force-pushed a formatting fix on the second commit