Conversation
clintval
approved these changes
Nov 8, 2024
ci/update-version
Outdated
Comment on lines
+43
to
+56
| echo "Updating pyproject.toml to version: ${VERSION}" | ||
|
|
||
| case "$OSTYPE" in | ||
| darwin*|bsd*) | ||
| echo "Using BSD sed style" | ||
| sed_no_backup=( -i '' ) | ||
| ;; | ||
| *) | ||
| echo "Using GNU sed style" | ||
| sed_no_backup=( -i ) | ||
| ;; | ||
| esac | ||
|
|
||
| sed -E "${sed_no_backup[@]}" "s/^(version[[:space:]]+=[[:space:]])\"(.*)\"/\1\"${VERSION}\"/" pyproject.toml |
Member
There was a problem hiding this comment.
I realize if poetry is available you could do: poetry version ${NEW_VERSION}. And it will Just Work!
Collaborator
Author
There was a problem hiding this comment.
Poetry is way cleaner! That's a great solution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a
ci/update-versionscript which can be used to update the version stored inpyproject.toml.It also adds a github action triggered by a workflow dispatch (GUI) that will:
One thing to note is that we're using the github action token for these steps, so the initial commit and pull request will not trigger other automations. When a user merges the pull request, that merge commit will trigger other automations.
See this action trigger: https://github.com/seqwell/longplexpy/actions/runs/11746405567
From this PR: #7
Remaining automation steps:
chore(#.#.#)commit messagedocker-build-imagescript).