Skip to content
This repository was archived by the owner on May 28, 2024. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions app/controllers/sessions_controller.rb
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@ def create
omniauth_uid: auth['uid']
).first || User.create_with_omniauth(auth)

user.update!(email: auth['info']['email'])

session[:user_id] = user.id
return redirect_to params[:return_to] if params[:return_to].present?
end
Expand Down
23 changes: 23 additions & 0 deletions app/helpers/application_helper.rb
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
# -*- encoding : utf-8 -*-
require 'kramdown'
require 'digest/md5'
require 'uri'

module ApplicationHelper

Expand Down Expand Up @@ -51,4 +53,25 @@ def markdown(md_body)
md_body
end
end

def gravatar_image(user, options = {})
return nil if user.nil? || user.email.nil?

hash = Digest::MD5.hexdigest(user.email.downcase)
query = options.select { |k, v| [:size, :default].include?(k) }
.map { |k, v| "#{k}=#{URI.encode(v.to_s)}" }
.join('&')
src = "//www.gravatar.com/avatar/#{hash}?#{query}"

img_options = { :alt => user.nickname }
if mouseover = options[:mouseover]
img_options = mouseover
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, this line should be img_options[:mouseover] = mouseover!

end
if size = options[:size]
img_options[:width] = size
img_options[:height] = size
end

image_tag(src, img_options)
end
end
1 change: 1 addition & 0 deletions app/models/user.rb
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ def self.create_with_omniauth(auth)
create! do |user|
user.omniauth_provider = auth['provider']
user.omniauth_uid = auth['uid']
user.email = auth['info']['email']
user.nickname = nil
end
end
Expand Down
4 changes: 3 additions & 1 deletion app/views/gists/_fork_of.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,9 @@
<%= time_ago_in_words(@gist.source_gist.created_at) + ' ago' %>
by
<% if @gist.source_gist.user.nil? %>Anonymous
<% else %><%= link_to @gist.source_gist.user.nickname, user_path(@gist.source_gist.user) %>
<% else %>
<%= link_to @gist.source_gist.user.nickname, user_path(@gist.source_gist.user) %>
<%= gravatar_image(@gist.source_gist.user, :size => 15) %>
<% end %>
</small>
</li>
Expand Down
4 changes: 3 additions & 1 deletion app/views/gists/_forks.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,9 @@
<%= time_ago_in_words(gist.created_at) + ' ago' %>
by
<% if gist.user.nil? %>Anonymous
<% else %><%= link_to gist.user.nickname, user_path(gist.user) %>
<% else %>
<%= link_to gist.user.nickname, user_path(gist.user) %>
<%= gravatar_image(gist.user, :size => 15) %>
<% end %>
</small>
</li>
Expand Down
8 changes: 6 additions & 2 deletions app/views/gists/_history.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,17 @@
<%= time_ago_in_words(history.created_at) + ' ago' %>
by
<% if history.user.nil? %>Anonymous
<% else %><%= link_to history.user.nickname, user_path(history.user) %>
<% else %>
<%= link_to history.user.nickname, user_path(history.user) %>
<%= gravatar_image(history.user, :size => 15) %>
<% end %>
<% else %>
<%= link_to time_ago_in_words(history.created_at) + ' ago', show_history_gist_path(@gist, history) %>
by
<% if history.user.nil? %>Anonymous
<% else %><%= link_to history.user.nickname, user_path(history.user) %>
<% else %>
<%= link_to history.user.nickname, user_path(history.user) %>
<%= gravatar_image(history.user, :size => 15) %>
<% end %>
<% end %>
</small>
Expand Down
1 change: 1 addition & 0 deletions app/views/gists/_list.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
Anonymous
<% else %>
<%= link_to gist.user.nickname, user_path(gist.user) %>
<%= gravatar_image(gist.user, :size => 20) %>
<% end %>
</small>
</div>
Expand Down
4 changes: 3 additions & 1 deletion app/views/root/index.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,9 @@
<%= time_ago_in_words(gist.latest_history.created_at) + ' ago' %>
by
<% if gist.user.nil? %>Anonymous
<% else %><%= link_to gist.user.nickname, user_path(gist.user) %>
<% else %>
<%= link_to gist.user.nickname, user_path(gist.user) %>
<%= gravatar_image(gist.user, :size => 20) %>
<% end %>
</small>
</div>
Expand Down
8 changes: 7 additions & 1 deletion app/views/users/show.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,10 @@

<%= render :partial => 'common/flash_notice' %>

<h2><%= @user.nickname %></h2>
<h2>
<%= gravatar_image(@user, :size => 30) %>
<%= @user.nickname %>
</h2>
<hr/>

<table class="table table-bordered">
Expand All @@ -12,6 +15,9 @@
<tr>
<td><%= @user.omniauth_uid %></td>
</tr>
<tr>
<td><%= @user.email %></td>
</tr>
</table>

<% if @user.id == current_user.try(:id) %>
Expand Down
5 changes: 5 additions & 0 deletions db/migrate/20140110041301_add_email_to_users.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
class AddEmailToUsers < ActiveRecord::Migration
def change
add_column :users, :email, :string
end
end
27 changes: 14 additions & 13 deletions db/schema.rb
Original file line number Diff line number Diff line change
Expand Up @@ -11,53 +11,54 @@
#
# It's strongly recommended that you check this file into your version control system.

ActiveRecord::Schema.define(version: 20121015023421) do
ActiveRecord::Schema.define(version: 20140110041301) do

create_table "comments", force: true do |t|
t.integer "gist_id", null: false
t.integer "user_id", null: false
t.text "body", null: false
t.datetime "created_at"
t.datetime "updated_at"
t.datetime "created_at", null: false
t.datetime "updated_at", null: false
end

create_table "favorites", force: true do |t|
t.integer "user_id", null: false
t.integer "gist_id", null: false
t.datetime "created_at"
t.datetime "updated_at"
t.datetime "created_at", null: false
t.datetime "updated_at", null: false
end

create_table "gist_files", force: true do |t|
t.string "name", null: false
t.text "body", null: false
t.integer "gist_history_id", null: false
t.datetime "created_at"
t.datetime "updated_at"
t.datetime "created_at", null: false
t.datetime "updated_at", null: false
end

create_table "gist_histories", force: true do |t|
t.integer "gist_id", null: false
t.integer "user_id"
t.datetime "created_at"
t.datetime "updated_at"
t.datetime "created_at", null: false
t.datetime "updated_at", null: false
end

create_table "gists", force: true do |t|
t.string "title", null: false
t.boolean "is_public", null: false
t.integer "user_id"
t.integer "source_gist_id"
t.datetime "created_at"
t.datetime "updated_at"
t.datetime "created_at", null: false
t.datetime "updated_at", null: false
end

create_table "users", force: true do |t|
t.string "nickname"
t.string "omniauth_provider", null: false
t.string "omniauth_uid", null: false
t.datetime "created_at"
t.datetime "updated_at"
t.datetime "created_at", null: false
t.datetime "updated_at", null: false
t.string "email"
end

end
35 changes: 26 additions & 9 deletions spec/controllers/sessions_controller_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -25,18 +25,35 @@ def valid_session

describe "GET /auth/:provider/callback" do
it "accepts requests without header" do
get :create, {:provider => 'open_id'}, valid_session
get :create, {:provider => 'open_id'}
expect(response.status).to eq(302)
expect(response).to redirect_to root_path
end
it "accepts requests" do
request.env['omniauth.auth'] = {
"provider" => 'open_id',
"uid" => "xxx"
}
get :create, {:provider => 'open_id', :return_to => '/foo'}, valid_session
expect(response.status).to eq(302)
expect(response).to redirect_to 'http://test.host/foo'
it "creates new user" do
expect {
request.env['omniauth.auth'] = {
'provider' => 'open_id',
'uid' => 'yyy',
'info' => { 'email' => 'test@test.org' }
}
get :create, {:provider => 'open_id'}
}.to change { User.count }.from(0).to(1)
u = User.first
expect(u.omniauth_provider).to eq('open_id')
expect(u.omniauth_uid).to eq('yyy')
expect(u.email).to eq('test@test.org')
end
it "updates existing user" do
expect {
request.env['omniauth.auth'] = {
'provider' => user.omniauth_provider,
'uid' => user.omniauth_uid,
'info' => { 'email' => 'test@test.org' }
}
get :create, {:provider => user.omniauth_provider}
}.not_to change { User.count }.from(1)
user.reload
expect(user.email).to eq('test@test.org')
end
end

Expand Down
23 changes: 20 additions & 3 deletions spec/models/user_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -8,14 +8,31 @@
expect(user).not_to be_nil
end

it 'create with omniauth' do
it 'create with omniauth without email' do
auth = {
"provider" => 'open_id',
"uid" => 'xxxxxx'
'provider' => 'open_id',
'uid' => 'xxxxxx',
'info' => {}
}
created = User.create_with_omniauth(auth)
expect(created.omniauth_provider).to eq('open_id')
expect(created.omniauth_uid).to eq('xxxxxx')
expect(created.email).to be_nil
expect(created.nickname).to be_nil
end

it 'create with omniauth with email' do
auth = {
'provider' => 'open_id',
'uid' => 'xxxxxx',
'info' => {
'email' => 'test@test.org'
}
}
created = User.create_with_omniauth(auth)
expect(created.omniauth_provider).to eq('open_id')
expect(created.omniauth_uid).to eq('xxxxxx')
expect(created.email).to eq('test@test.org')
expect(created.nickname).to be_nil
end

Expand Down
3 changes: 3 additions & 0 deletions spec/requests/gists_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@

describe "GET /gists" do
it "works" do
3.times do
create(:gist)
end
get gists_path
expect(response.status).to be(200)
end
Expand Down