Skip to content
This repository was archived by the owner on May 28, 2024. It is now read-only.

Conversation

sue445
Copy link
Contributor

@sue445 sue445 commented Jul 12, 2015

Why?

qiita-markdown is better than kramdown in markdown rendering

Example

Sample markdown

Before (Use kramdown)

gistub-before

After (Use qiita-markdown)

gistub-after

Breaking changes

@seratch
Copy link
Owner

seratch commented Jul 12, 2015

Dropping CRuby 1.9 is fine but I'd like to avoid dropping JRuby becuase users especially in China are running Gistub on the JVM. Using kramdown instead when JRuby is preferred.

@sue445 sue445 force-pushed the feature/qiita-markdown branch 2 times, most recently from 9e7bb62 to 551b2dc Compare July 12, 2015 01:26
@sue445 sue445 force-pushed the feature/qiita-markdown branch from 551b2dc to 66834c5 Compare July 12, 2015 01:46
qiita-markdown support only ruby 2.x+
@sue445 sue445 force-pushed the feature/qiita-markdown branch from 66834c5 to bb09942 Compare July 12, 2015 01:52
@sue445
Copy link
Contributor Author

sue445 commented Jul 12, 2015

Using kramdown instead when JRuby is preferred.

I see.

I changed implements at 3e872f6
Use both qiita-markdown(MRI) and kramdown(JRuby)

Please check again 🙇

@sue445 sue445 changed the title Change rendering engine of markdown (kramdown -> qiita-markdown) When MRI, change rendering engine of markdown (kramdown -> qiita-markdown) Jul 12, 2015
@seratch
Copy link
Owner

seratch commented Jul 12, 2015

Thanks. LGTM.

seratch added a commit that referenced this pull request Jul 12, 2015
When MRI, change rendering engine of markdown (kramdown -> qiita-markdown)
@seratch seratch merged commit 0a9fc4c into seratch:develop Jul 12, 2015
@sue445 sue445 deleted the feature/qiita-markdown branch July 12, 2015 05:54
@sue445
Copy link
Contributor Author

sue445 commented Jul 12, 2015

😍

@lukehorvat
Copy link

Hi @seratch, could you release a new version for this? Thanks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants