Conversation
To separate the platform logic in our CMake files the 3rd party dependency files and logic have all been moved into the dependencies/ folder. I tried creating a library output file that could be easily included in the root CMakeLists.txt but it was a lot more difficult than expected. Especially on Travis-CI where I gave up because of linker order build errors that wouldn't happen on any other platform (I gave up here: http://stackoverflow.com/a/19905704). * Add a CMakeLists.txt to encapsulate all dependency logic ** Expose dependency directories through: *** DEPENDENCIES_INCLUDES *** DEPENDENCIES_SOURCES *** DEPENDENCIES_LIBRARIES * Move Find*.cmake files into dependencies/ folder
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To separate the platform logic in our CMake files the 3rd party dependency files
and logic have all been moved into the dependencies/ folder. I tried creating a
library output file that could be easily included in the root CMakeLists.txt but
it was a lot more difficult than expected. Especially on Travis-CI where I gave
up because of linker order build errors that wouldn't happen on any other
platform (I gave up here: http://stackoverflow.com/a/19905704).