Some quick fixes and tidy-up #13
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always use display formatting at the top level for scalars - it turns out that it seems odd to see a
DateTimeend up as ISO-8601 in a log message.ConsoleThemeStyle.Object->ConsoleThemeStyle.Scalar(obsoleting the old name). This name was carried over from the old literate console sink and isn't representative of what the color means, which is, a scalar-captured value of type other than number, bool or string.Color JSON based on the underlying capture type to distinguish actual strings from other scalars.
Ugly example, showing the difference between rendering of a top-level
DateTimeand one embedded within a structure. Also note that only the actualstringusesConsoleThemeStyle.String- the number, rendered as the string"NaN", uses number coloring, and likewise theDateTime"Utc"uses scalar coloring.In real log data, where most entries are real strings and regular numbers, this isn't so ridiculously colorful ;-)