fix: restore numeric vector outputs#63
Conversation
Signed-off-by: nvphungdev <283886185+nvphungdev@users.noreply.github.com>
serkor1
left a comment
There was a problem hiding this comment.
Hi @nvphungdev ,
Thank you so much for taking the time to submit a (almost mergable) PR. This is highly appreciated.
I have added a few comments that needs to be resolved before it can merged, but they are really minor.
Generally the lookback attribute is meant for the charting API, what is the rationale for adding the attribute in the numeric method? Have I missed something here?
Best,
Signed-off-by: nvphungdev <283886185+nvphungdev@users.noreply.github.com>
|
Hi @serkor1 |
|
Awesome! Great work, thank you so much. I will merge the branch ASAP. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## devel #63 +/- ##
==========================================
+ Coverage 96.58% 96.67% +0.09%
==========================================
Files 280 280
Lines 21012 21012
==========================================
+ Hits 20294 20314 +20
+ Misses 718 698 -20 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Summary
Validation
bash -n codegen/generate_unit-tests.shgit diff --checkrg "is.null\(dim\(x\)\)|numeric methods returns <matrix>" R codegen tests -n(no matches)R/Rscriptare unavailable in this environment.Fixes #61