Skip to content

WIP add best practices#2

Draft
dniku wants to merge 1 commit intomasterfrom
thatguy/best-practices
Draft

WIP add best practices#2
dniku wants to merge 1 commit intomasterfrom
thatguy/best-practices

Conversation

@dniku
Copy link

@dniku dniku commented Mar 14, 2019

No description provided.

@dniku dniku self-assigned this Mar 14, 2019
@gromakovsky
Copy link
Member

gromakovsky commented Jul 15, 2020

I'd move suggestion to use weeder here.

gromakovsky added a commit that referenced this pull request Jul 15, 2020
@gromakovsky
Remove mentions of weeder
e676822 
Problem: I think suggestions to use `weeder` should be part of
"best practices" (see #2),
not part of style guide. It's a useful tool, but mentioning it in
the style guide seems to unnecessaily increase its size.

Solution: remove mentions, write about it to #2.
gromakovsky added a commit that referenced this pull request Jul 15, 2020
@gromakovsky
Remove mentions of weeder
eeb300b 
Problem: I think suggestions to use `weeder` should be part of
"best practices" (see #2),
not part of style guide. It's a useful tool, but mentioning it in
the style guide seems to unnecessaily increase its size.

Solution: remove mentions, write about it to #2.
gromakovsky added a commit that referenced this pull request Jul 15, 2020
@gromakovsky
Remove mentions of weeder
0868d14 
Problem: I think suggestions to use `weeder` should be part of
"best practices" (see #2),
not part of style guide. It's a useful tool, but mentioning it in
the style guide seems to unnecessaily increase its size.

Solution: remove mentions, write about it to #2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@dniku dniku

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dniku @gromakovsky