Skip to content

enable webpackIncludeModules for webpack-no-watch#293

Closed
seriouscoderone wants to merge 1 commit intoserverless-heaven:masterfrom
seriouscoderone:master
Closed

enable webpackIncludeModules for webpack-no-watch#293
seriouscoderone wants to merge 1 commit intoserverless-heaven:masterfrom
seriouscoderone:master

Conversation

@seriouscoderone
Copy link
Copy Markdown
Contributor

I got this for webpack-no-watch, not sure how to do this for the watch mode.

I got this for webpack-no-watch, not sure how to do this for the watch mode.
@HyperBrain
Copy link
Copy Markdown
Member

Hi @josephleehunsaker, first thanks for you engagement.

Can you please tell, what exactly the problem is, that this PR should solve? As background: The wpwatch function is only used by serverless-offline which uses the locally available node_modules and does not need an extra packaging step. So the PR will add quite some additional time to the startup (and recompiles if it is added to watch too), eventually rendering local debugging very hard.

If you want to test the final package (as it would be deployed to AWS), you should use serverless run. The plugin fully integrates with that, and there the final package will be automatically uploaded into a Serverless Docker image that emulates the API and the lambdas.

@seriouscoderone
Copy link
Copy Markdown
Contributor Author

Thx @HyperBrain for the background. So I just use serverless run instead of serverless offline? Or do I need to run both in separate terminals?

@HyperBrain
Copy link
Copy Markdown
Member

It's an either or. If you mant to test the final deployment, use serverless run, if you want to quickly test during development, use serverless offline. The two methods are unrelated and can be used independently.
Asking your question: Just use serverless run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants