Unable to create Step function Permissions when $AWS:Partition is used

[liamquilter-gen]

Hey,

We are facing an issue when we use
Resource: arn:${AWS::Partition}:states:::states:startExecution.sync
it fails to create the iam role permission for that step function
"Action": [ "states:StartExecution" ], "Resource": [ "arn:aws:states:us-east-1:929447382720:stateMachine:service-stepFunction",
is what it should be but doesn't create this
We believe the line that needs to be updated is
https://github.com/serverless-operations/serverless-step-functions/blob/master/lib/deploy/stepFunctions/compileIamRole.js#L467

Any help regarding this would be greatly appreciated.

[zirkelc]

@liamquilter-gen I prepared a fix in #661

Could you please give it a try before I merge it:

npm i https://pkg.pr.new/serverless-operations/serverless-step-functions@661

[liamquilter-gen]

Testing this is proving difficult locally,

Have tested multiple scenarios of this, these ways don't work.

Resource:
      - Fn:Sub: "arn:${AWS::Partition}:states:::states:startExecution.sync"

Resource: !Sub "arn:${AWS::Partition}:states:::states:startExecution.sync"

This does correctly sub in the permissions for the step functions role, but unsure if the partition will be able to sub this in correctly during deployment
Resource: "arn:${AWS::Partition}:states:::states:startExecution.sync"

[zirkelc]

How did you test it? Since {AWS::Partition}is an AWS pseudo value, you probably need to deploy the stack in order to see if it works. Serverless does not replace it manually.

[liamquilter-gen]

By generating the cloudformation templates locally, and seeing do the step functions role get generated correctly.
I finally managed to use the pre release version in a full deploy and for
Resource: "arn:${AWS::Partition}:states:::states:startExecution.sync"
it has successfully made the role for starting the execution
Thank you for the help