This repository was archived by the owner on Dec 9, 2024. It is now read-only.
Fixed compile issue #160 on windows #161
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjlittle
approved these changes
Jun 6, 2019
Contributor
|
LGTM. Wasn't aware of the |
Fixed compile issue serverless#160 on windows by adding shx npm package to use in build scripts. Also added some local dev instructions to Readme.md Made numbering in local dev instructions in readme.md sequential. Signed Commit Made numbering in local dev sintructions in readme.md sequential.
…ge to use in build scripts. Also added some local dev instructions to Readme.md
wbreza
suggested changes
Jun 7, 2019
Contributor
wbreza
left a comment
wbreza
left a comment
There was a problem hiding this comment.
Please remove the shx dependency. It should not be required since rm command is available cross platform.
wbreza
approved these changes
Jun 11, 2019
mydiemho
approved these changes
Jun 12, 2019
Contributor
mydiemho
left a comment
mydiemho
left a comment
There was a problem hiding this comment.
comment to add one more steps before linking code
tbarlow12
pushed a commit
that referenced
this pull request
Sep 13, 2019
Fixed compile issue #160 on windows by adding shx npm package to use in build scripts. Also added some local dev instructions and contribution hints to Readme.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added shx npm package to use in build scripts. Fixes #160
Also added some local dev instructions to Readme.md.