This repository was archived by the owner on Dec 9, 2024. It is now read-only.
fix: Simple fix in test of equality comparison #179
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjlittle
approved these changes
Jun 25, 2019
mydiemho
approved these changes
Jun 25, 2019
Contributor
mydiemho
left a comment
mydiemho
left a comment
There was a problem hiding this comment.
lgtm, just some suggestions
| expect(result).toBeNull(); | ||
| }); | ||
|
|
||
| it("gets master key", async () => { |
Contributor
There was a problem hiding this comment.
suggestion: rename test description to start with should/should not
| const service = createService(); | ||
| const masterKey = await service.getMasterKey(); | ||
| expect(masterKey).toEqual(masterKey); | ||
| const result = await service.getMasterKey(); |
Contributor
There was a problem hiding this comment.
nit: I would call this actualMasterKey
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered this small bug in the test. Overloading the variable name
masterKey, usingresultinstead.