Skip to content
This repository was archived by the owner on Dec 9, 2024. It is now read-only.

fix: Simple fix in test of equality comparison #179

Merged
merged 1 commit into from
Jun 25, 2019
Merged

fix: Simple fix in test of equality comparison #179

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/services/functionAppService.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,8 +107,8 @@ describe("Function App Service", () => {

it("gets master key", async () => {
Copy link
Contributor

@mydiemho mydiemho Jun 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: rename test description to start with should/should not

Copy link
Contributor Author

@tbarlow12 tbarlow12 Jun 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will do

const service = createService();
const masterKey = await service.getMasterKey();
expect(masterKey).toEqual(masterKey);
const result = await service.getMasterKey();
Copy link
Contributor

@mydiemho mydiemho Jun 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I would call this actualMasterKey

Copy link
Contributor Author

@tbarlow12 tbarlow12 Jun 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will do

expect(result).toEqual(masterKey);

});

Expand Down