Serverless plugin "serverless-google-cloudfunctions" initialization errored: Unexpected token )

[knitterb]

When doing a fresh install of the plugins (npm install) I get the error in the title when issuing the serverless help command. Further debugging profiles the following:

SyntaxError: Unexpected token )
node_modules/serverless-google-cloudfunctions/package/lib/compileFunctions.js:43
      );
      ^

I took a look in the file and there appears to be an extra comma that is not tolerated:

40      funcTemplate.properties.labels = _.assign({},
41        _.get(this, 'serverless.service.provider.labels') || {},
42        _.get(funcObject, 'labels') || {},
43      );
44
45      const eventType = Object.keys(funcObject.events[0])[0];

The comma at the end of line 42, when removed, let's everything function as it should.

  Your Environment Information -----------------------------
     OS:                     darwin
     Node Version:           6.11.5
     Serverless Version:     1.28.0

Let me know what else I can provide to help!

[knitterb]

Same error on latest Node version:

  Your Environment Information -----------------------------
     OS:                     darwin
     Node Version:           6.14.3
     Serverless Version:     1.28.0

[TimNZ]

@knitterb Submit a PR?

[knitterb]

Let me do that next week!

…

-- -bk

On Thu, Aug 9, 2018, 14:53 Tim Shnaider ***@***.***> wrote: @knitterb <https://github.com/knitterb> Submit a PR? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#110 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAKJnmMUmLqOaq_gJ-eMIN_KFNskVW6Zks5uPK9UgaJpZM4VVa9W> .

[knitterb]

Submitted PR @TimNZ

[tchupp]

The Node v10 linting fails with this change. Does that mean the the eslint rules break compatibility with Node v6?

> serverless-google-cloudfunctions@2.0.0 lint /home/travis/build/serverless/serverless-google-cloudfunctions
> eslint . --cache
/home/travis/build/serverless/serverless-google-cloudfunctions/package/lib/compileFunctions.js
  48:42  error  Missing trailing comma  comma-dangle

[feliperbroering]

$ serverless deploy

  Serverless Error ---------------------------------------

  Serverless plugin "serverless-google-cloudfunctions" initialization errored: Unexpected token )

  Get Support --------------------------------------------
     Docs:          docs.serverless.com
     Bugs:          github.com/serverless/serverless/issues
     Issues:        forum.serverless.com

  Your Environment Information -----------------------------
     OS:                     darwin
     Node Version:           6.14.4
     Serverless Version:     1.30.1

[pickypg]

@tclchiam Given that GCP only supports Node 6.14 and, in beta, Node 10 8, shouldn't the concern be about working with those versions more than Node 10?

[tchupp]

@pickypg I agree, the priority would be maintaining compatibility with all Node versions.

The only argument I could see against is that this package isn't part of the runtime, just the development & CI pipeline; but that doesn't seem like an acceptable reason to break compatibility.

[ursbrbalaji]

As the build failed, because of linting issues. Anybody figured a way to solve this?

[erikerikson]

This snippet is from our eslintrc.yml:

  # Note: this is to prevent compile errors for Node < 8.x. When Node 6 is
  #   deprecated, this comma-dangle rule exception can be removed.
  comma-dangle:
    - error
    - arrays: always-multiline
      objects: always-multiline
      imports: ignore
      exports: ignore
      functions: never

Probably a more targeted approach would be to use the comment at the end of the line:

// eslint-disable-line comma-dangle

[erikerikson]

That change is offered, I'll ping the maintainers once accepted

[erikerikson]

In the meantime, a workaround is to use node version 8 or greater

[knitterb]

Thanks for that lint fix!

…

-- -bk

On Mon, Oct 29, 2018 at 3:05 PM Erik Erikson ***@***.***> wrote: This snippet is from our eslintrc.yml: # Note: this is to prevent compile errors for Node < 8.x. When Node 6 is # deprecated, this comma-dangle rule exception can be removed. comma-dangle: - error - arrays: always-multiline objects: always-multiline imports: ignore exports: ignore functions: never Probably a more targeted approach would be to use the comment at the end of the line: // eslint-disable-line comma-dangle — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#110 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAKJnr0E1pvDfjKNODGELkprxlWaEN9Jks5up3upgaJpZM4VVa9W> .