Skip to content
This repository was archived by the owner on Oct 24, 2025. It is now read-only.

Fix related to test#193

Merged
dschep merged 2 commits intoserverless:masterfrom
abetomo:clean_files_used_for_testing
May 21, 2018
Merged

Fix related to test#193
dschep merged 2 commits intoserverless:masterfrom
abetomo:clean_files_used_for_testing

Conversation

@abetomo
Copy link
Copy Markdown
Contributor

@abetomo abetomo commented May 18, 2018

  • Add file to clean in test teardown
    • Because git is displayed in an untracked file
  • Fix package.json of test according to the current version
    • Because it was displayed in git diff

abetomo added 2 commits May 18, 2018 15:21
@abetomo
Add file to clean in test teardown
dceb7ca 
Because git is displayed in an untracked file
@abetomo
Fix package.json of test according to the current version
4f47778 
Because it was displayed in `git diff`.
dschep
dschep approved these changes May 21, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@dschep dschep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @abetomo!

@dschep dschep merged commit d4e199c into serverless:master May 21, 2018
@abetomo abetomo deleted the clean_files_used_for_testing branch May 22, 2018 00:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@dschep dschep dschep approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@abetomo @dschep