Skip to content
This repository was archived by the owner on Oct 24, 2025. It is now read-only.

Conversation

@dschep
Copy link
Contributor

@dschep dschep commented Sep 20, 2018

Main advantage is that these can run on windows more easily, thus fixes #249

cc @AndrewFarley @kichik @heri16

@AndrewFarley
Copy link
Contributor

This is great @dschep thanks for bootstrapping this. If you want a hand with something in particular or a second eye let me know. Happy to help. Cheers!

@dschep
Copy link
Contributor Author

dschep commented Sep 20, 2018

Thanks @AndrewFarley. I currently need help debugging the errors with npm not being found by spawnSync in appveyor, if someone with Windows could try to run the tests locally (clone this branch, then: npm i && node test.js) that would be much appreciated. For further help, I'm gonna first get the skip conditions worked out (ie: when not to run the docker tests) and then I'll probably want some help just porting over the remaining tests.

edit: nevermind re debugging spawnSync, googling explained the issue and switching to cross-spawn did the trick.

@dschep
Copy link
Contributor Author

dschep commented Sep 21, 2018

woo hooo. tests passing. temporarily cherrypicked a "fix" for #252 to make it happen

precursor to JS version since i want it as simple as possible before port
Main advantage is that these can run on windows more easily, thus fixing #249
@dschep
Copy link
Contributor Author

dschep commented Oct 11, 2018

Merging this now as it's already way better than the current(broken) windows test coverage.

@dschep dschep merged commit 7245bcc into master Oct 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add proper windows CI test coverage

3 participants