This repository was archived by the owner on Oct 24, 2025. It is now read-only.
Add ability to define own Docker image (Issue 39) #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zampettim
changed the title
dschep
suggested changes
Jul 12, 2017
Contributor
dschep
left a comment
dschep
left a comment
There was a problem hiding this comment.
i like it! just a minor simplification if you don't mind 😃
index.js
Outdated
| if (this.custom().dockerizePip) { | ||
| cmd = 'docker'; | ||
|
|
||
| let image = `lambci/lambda:build-${runtime}` |
Contributor
There was a problem hiding this comment.
mind simplifying to this?
const image = this.custom().dockerImage || `lambci/lambda:build-${runtime}`;
Author
There was a problem hiding this comment.
I don't have any issues. I'm not much of a JS developer, so whatever you think is best. I'll update the PR in a minute.
dschep
approved these changes
Jul 12, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ability to define the docker image to use for the build.