This repository was archived by the owner on Oct 24, 2025. It is now read-only.
fix: check if pyproject has poetry earlier #477
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsamuel-ui
approved these changes
Feb 25, 2020
Contributor
Author
|
Will repair tonight/tomorrow. This is a classic case of splitting up the ci job to workflows - get that fast feedback on the lint before the beefy test suite. |
During the evaluation in the package phase, we determine whether a `requirements.txt` file exists, or whether we need to generate one. Since the `pyproject.toml` file is used by poetry, but only if a stanza is contained inside the file, use the function `isPoetryProject()` along with the configuration value, thereby reducing the need for a project to have to declare a configuration override. Refs serverless#324 Refs serverless#344 Fixes serverless#400 Signed-off-by: Mike Fiedler <miketheman@gmail.com>
miketheman
force-pushed
the
miketheman/fix-400
branch
from
7d11e8a to
17cbf9c
Compare
revmischa
reviewed
Mar 21, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the evaluation in the package phase, we determine whether a
requirements.txtfile exists, or whether we need to generate one.Since the
pyproject.tomlfile is used by poetry, but only if a stanzais contained inside the file, use the function
isPoetryProject()alongwith the configuration value, thereby reducing the need for a project to
have to declare a configuration override.
Refs #324
Refs #344
Fixes #400
Signed-off-by: Mike Fiedler miketheman@gmail.com