This repository was archived by the owner on Oct 24, 2025. It is now read-only.
Create include array for zip step if undefined #89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miketheman
commented
Oct 17, 2017
| } | ||
|
|
||
| @test "py3.6 can package flask with zip option and no explicit include" { | ||
| sed -i'.bak' -e 's/zip: *false/zip: true/' -e 's/include://' -e 's/^.*handler.py//' serverless.yml |
Contributor
Author
There was a problem hiding this comment.
Apologies here - I spent 15 minutes trying to get the right sed syntax for multiline in one expression before smashing my keyboard and writing the second expression.
dschep
reviewed
Oct 17, 2017
Contributor
dschep
left a comment
dschep
left a comment
There was a problem hiding this comment.
LGTM! and no worries about the multiple expressions, that's the better solution anyway IMO 😉
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #16
Similar to 6c5523c
Signed-off-by: Mike Fiedler miketheman@gmail.com