-
Notifications
You must be signed in to change notification settings - Fork 5.7k
fix(AWS API Gateway): Silence timeout warning for async: true
#8748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… 30 seconds APIGW limit removed.
Codecov Report
@@ Coverage Diff @@
## master #8748 +/- ##
==========================================
+ Coverage 87.43% 87.75% +0.31%
==========================================
Files 256 264 +8
Lines 9631 9780 +149
==========================================
+ Hits 8421 8582 +161
+ Misses 1210 1198 -12
Continue to review full report at Codecov.
|
pgrzesik
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @MEGApixel23, thanks for submitting a PR 🙇 As mentioned in corresponding issue, we're trying to use runServerless for any new test cases added, you can find the reference: https://github.com/serverless/serverless/blob/master/test/README.md
…http event the warning about > 30 seconds APIGW limit removed.
|
Hi, @pgrzesik! The requested changes have been done. Please, let me know if there anything else that needs to be done. |
pgrzesik
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @MEGApixel23, it looks good overall, I have few cosmetic comments, please let me know what do you think 🙇
|
@pgrzesik Thank you for the feedback. All done! |
pgrzesik
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you @MEGApixel23 👍
async: true
Closes: #8739