Skip to content

Conversation

@MEGApixel23
Copy link
Contributor

Closes: #8739

@codecov
Copy link

codecov bot commented Jan 12, 2021

Codecov Report

Merging #8748 (7e86f46) into master (2b7568a) will increase coverage by 0.31%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8748      +/-   ##
==========================================
+ Coverage   87.43%   87.75%   +0.31%     
==========================================
  Files         256      264       +8     
  Lines        9631     9780     +149     
==========================================
+ Hits         8421     8582     +161     
+ Misses       1210     1198      -12     
Impacted Files Coverage Δ
lib/plugins/aws/deploy/lib/extendedValidate.js 100.00% <100.00%> (+2.38%) ⬆️
...ib/plugins/aws/utils/getLambdaLayerArtifactPath.js 83.33% <0.00%> (-16.67%) ⬇️
lib/utils/getServerlessConfigFile.js 90.69% <0.00%> (-3.42%) ⬇️
lib/Serverless.js 96.49% <0.00%> (-0.71%) ⬇️
lib/plugins/aws/lib/naming.js 97.63% <0.00%> (-0.56%) ⬇️
lib/classes/Error.js 95.45% <0.00%> (-0.55%) ⬇️
lib/plugins/package/lib/packageService.js 95.95% <0.00%> (-0.47%) ⬇️
lib/classes/CLI.js 92.81% <0.00%> (-0.22%) ⬇️
lib/plugins/aws/invokeLocal/index.js 67.50% <0.00%> (-0.19%) ⬇️
lib/plugins/aws/package/compile/functions.js 96.02% <0.00%> (-0.17%) ⬇️
... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b7568a...7e86f46. Read the comment docs.

Copy link
Contributor

@pgrzesik pgrzesik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @MEGApixel23, thanks for submitting a PR 🙇 As mentioned in corresponding issue, we're trying to use runServerless for any new test cases added, you can find the reference: https://github.com/serverless/serverless/blob/master/test/README.md

@MEGApixel23
Copy link
Contributor Author

Hi, @pgrzesik! The requested changes have been done. Please, let me know if there anything else that needs to be done.

Copy link
Contributor

@pgrzesik pgrzesik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @MEGApixel23, it looks good overall, I have few cosmetic comments, please let me know what do you think 🙇

@MEGApixel23
Copy link
Contributor Author

@pgrzesik Thank you for the feedback. All done!

Copy link
Contributor

@pgrzesik pgrzesik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you @MEGApixel23 👍

@pgrzesik pgrzesik changed the title fix: When timeout is applied to async: true http event the warning about > 30 seconds APIGW limit removed fix(AWS API Gateway): Silence timeout warning for async: true Jan 19, 2021
@pgrzesik pgrzesik merged commit 0384776 into serverless:master Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

When using async: true HTTP event and setting the timeout > 30 seconds WARNING is shown

2 participants