Variables: Improve resolution queuing and related cleanup #10652
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's harmless, and given config option is not documented
4 tasks
Codecov Report
@@ Coverage Diff @@
## main #10652 +/- ##
==========================================
- Coverage 86.42% 86.40% -0.03%
==========================================
Files 299 299
Lines 12376 12377 +1
==========================================
- Hits 10696 10694 -2
- Misses 1680 1683 +3
Continue to review full report at Codecov.
|
medikoo
force-pushed
the
0207-improve-vars-handling
branch
from
e936df4 to
5587f93
Compare
medikoo
force-pushed
the
0207-improve-vars-handling
branch
from
5587f93 to
87407f4
Compare
pgrzesik
approved these changes
Feb 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve variable resolution queuing logic.
It also fixes one shortcoming, where after registering all non-AWS specific sources, logic immediately moved to validation on whether properties that influence AWS authentication logic are resolved.
This patch ensure that we attempt to re-resolve those properties having additional information, before validating them. This e.g. allows to configure
provider.profilewithparamvariable sources.Fixes #10642
Additionally dropped support for
enterpriseDisableduser configuration property, which didn't seem to be documented anywhere, and if used it prevented to useparamvariables, even with no dashboard enabled in service config.