Add provider awareness for plugins #1465
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
lib/classes/PluginManager.js
Outdated
| if (hooks.length === 0) { | ||
| const errorMessage = `The command you entered was not found. | ||
| Did you spell it correctly?`; | ||
| Did you spell it correctly?`; |
Contributor
There was a problem hiding this comment.
yeah we gotta be careful with string template literals ... every space/return we make will affect how the error is displayed in the terminal. For best guaranteed quality i prefer the ['error line1, 'error line2'].join(''); pattern
Contributor
There was a problem hiding this comment.
Could you confirm that this message is printed correctly? otherwise could you switch to the convention I shared above?
Contributor
Author
There was a problem hiding this comment.
Woop woop. Good catch! Sorry that was just a "this should be indented correctly" move.
Will update it!
pmuens
force-pushed
the
add-provider-awareness-for-plugins
branch
from
a8f607d to
dfa15aa
Compare
This was referenced Aug 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plugins can now have a
providerdefinition inside the constructor.If defined Serverless fill only consider the plugin if the
providerdefinition of the service matches the one of the plugins.All other plugins who have no provider definition will always be considered.